Re: [PATCH 2/3] http: try standard proxy env vars when http.proxy config option is not set
- From
- Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es>
- Date
- Mar 15, 2012, 09:38 UTC
- Message-ID
- <4F61B892.8030604@seap.minhap.es>
- In-Reply-To
- <7v1uouq5j9.fsf@alter.siamese.dyndns.org>
On 03/14/2012 09:41 PM, Junio C Hamano wrote:
Show 19 quoted lines
> Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es> writes: > >> On 03/14/2012 05:36 AM, Junio C Hamano wrote: >> >>> Are you sure $no_proxy is spelled in lowercase? man curl(1) seems to >>> indicate otherwise. >> >> Instead here[1] in section "Environment Variables" it's spelled lowercase, >> and given that cURL reads $http_proxy only in lowercase I think it does >> the same for $no_proxy. > > Don't think, but read ;-). Quoting from man curl(1): > > ENVIRONMENT > > The environment variables can be specified in lower case or upper > case. The lower case version has precedence. http_proxy is an > exception as it is only available in lower case. >
Ok, good advice nonetheless :-), so will send a new 1/5 patch that also reads $NO_PROXY.