Re: [PATCH 2/3] http: try standard proxy env vars when http.proxy config option is not set
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 28, 2012, 19:24 UTC
- Message-ID
- <7v62eqzrqm.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <878vjn8823.fsf@thomas.inf.ethz.ch>
Thomas Rast <trast@inf.ethz.ch> writes:
Show 7 quoted lines
> Which raises the questions: > > * Why is this needed? Does git's use of libcurl ignore http_proxy? [1] > seems to indicate that libcurl respects <protocol>_proxy > automatically. > > * Why do you (need to?) support HTTP_PROXY when curl doesn't?
Let me add a third bullet point.
I've heard rumors that libcurl on some versions/installations of Mac OS X deliberately ignores the environment. For those who agree with Apple, it would be a regression if we suddenly start the environment ourselves and using it.