Re: [PATCH 2/3] http: try standard proxy env vars when http.proxy config option is not set
- From
- Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es>
- Date
- Mar 13, 2012, 10:22 UTC
- Message-ID
- <4F5F1FEA.8020103@seap.minhap.es>
- In-Reply-To
- <7v4ntvx87v.fsf@alter.siamese.dyndns.org>
On 03/11/2012 08:12 PM, Junio C Hamano wrote:
Show 13 quoted lines
> James Cloos <cloos@jhcloos.com> writes: > >> Please include a way, eg via ~/.gitconfig, to ignore any http_proxy in >> the environment and connect directly. > > Hrm. > > I think without this patch series, the "NO_PROXY" environment > variable is honored by the curl library when it uses http_proxy > to make the decision. If this patch (or a future reroll of it) fails > to do the same, it would be a regression. > > Nelson, do you agree?
I agree, so I would need to handle $no_proxy in the patch-set, will look into that.