Re: [PATCH 2/3] http: try standard proxy env vars when http.proxy config option is not set
- From
- Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es>
- Date
- Mar 1, 2012, 10:18 UTC
- Message-ID
- <4F4F4D05.8080201@seap.minhap.es>
- In-Reply-To
- <7vlinltsja.fsf@alter.siamese.dyndns.org>
On 02/29/2012 07:15 PM, Junio C Hamano wrote:
Show 20 quoted lines
> Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es> writes: > >> On 02/28/2012 08:24 PM, Junio C Hamano wrote: >> >>> I've heard rumors that libcurl on some versions/installations of Mac OS X >>> deliberately ignores the environment. For those who agree with Apple, it >>> would be a regression if we suddenly start the environment ourselves and >>> using it. >> >> Hi Junio, what did you mean by "we start the environment and using it"? >> I didn't understand what you mean there.. > > The reason you didn't understand is because the statement does not parse > X-<. Thanks for pointing it out. > > What I meant was that on these platforms, allegedly (note that I do not > have a first-hand experience with them), user's http_proxy environment > setting did not affect libcurl based applications and that is a deliberate > platform decision to give precedence to proxy settings the platform has > elsewhere. The users who agree with this platform decision are happily
I googled for that but didn't find any info, anyway if that's true did they do this by 1) removing http_proxy from environment or by 2) patching libcurl not to read them ? if it's the first case, we are safe as they will also remove the vars and we won't read them, if it's second case, it's silly on their part as any other console program will be reading env vars as they would need to patch every program..
The normal thing os's do (as gnome used to do) is to automatically set the http_proxy env vars when you set a proxy on the GUI..
Show 7 quoted lines
> using the proxy settings stored elsewhere in the platform with git, but > may have http_proxy environment pointing at a proxy that they do not want > to use for git. > > If we suddenly start reading from http_proxy environment ourselves and > explicitly telling libcurl to use the proxy specified, it will change the > behaviour for these users, i.e. a regression.