git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] launch_editor(): allow spaces in the filename

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 10, 2008, 21:37 UTC
Message-ID
<7vk5kai7kr.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<200803102232.13727.johannes.sixt@telecom.at>
Johannes Sixt <johannes.sixt@telecom.at> writes:
Show 13 quoted lines
> On Monday 10 March 2008 21:42, Johannes Schindelin wrote:
>> For some reason, the construct
>>
>> 	sh -c "$0 \"$@\"" <editor> <file>
>>
>> does not pick up quotes in <editor> as expected.  So replace $0 with
>> <editor>.
>
> No surprise. It must be
>
> 	sh -c '"$0" "$@"' <editor> <file>
>
> Note the extra quotes around $0.

... assuming that there is no dq, $var_reference and other nastiness in <editor> ;-)

Previous: Johannes SixtNext: Johannes Sixt
Message 3 of 11 in “launch_editor(): allow spaces in the filename”
  1. launch_editor(): allow spaces in the filenameJohannes Schindelin, Mar 10, 2008
  2. Johannes SixtMar 10, 2008
  3. Junio C HamanoMar 10, 2008
  4. Johannes SixtMar 10, 2008
  5. Johannes SchindelinMar 10, 2008
  6. Junio C HamanoMar 10, 2008
  7. Junio C HamanoMar 10, 2008
  8. Junio C HamanoMar 10, 2008
  9. Johannes SchindelinMar 10, 2008
  10. Junio C HamanoMar 11, 2008
  11. launch_editor(): allow spaces in the filenameJohannes Schindelin, Mar 11, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.