Re: [PATCH] launch_editor(): allow spaces in the filename

From: Johannes Sixt <johannes.sixt@telecom.at>
Date: Mar 10, 2008, 21:46 UTC
Message-ID: <200803102246.13910.johannes.sixt@telecom.at>
In-Reply-To: <7vk5kai7kr.fsf@gitster.siamese.dyndns.org>

On Monday 10 March 2008 22:37, Junio C Hamano wrote:

Show 17 quoted lines

> Johannes Sixt <johannes.sixt@telecom.at> writes:
> > On Monday 10 March 2008 21:42, Johannes Schindelin wrote:
> >> For some reason, the construct
> >>
> >> 	sh -c "$0 \"$@\"" <editor> <file>
> >>
> >> does not pick up quotes in <editor> as expected.  So replace $0 with
> >> <editor>.
> >
> > No surprise. It must be
> >
> > 	sh -c '"$0" "$@"' <editor> <file>
> >
> > Note the extra quotes around $0.
>
> ... assuming that there is no dq, $var_reference and other nastiness in
> <editor> ;-)

They are not a problem; there isn't yet another level of evaluation. I just tried with an <editor> that goes by this name:

   f "$DISPLAY"b

and I got the expected result, i.e. it was found and executed.

-- Hannes