From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 10 Mar 2008 21:37:40 GMT
Subject: Re: [PATCH] launch_editor(): allow spaces in the filename
Message-ID: <7vk5kai7kr.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <200803102232.13727.johannes.sixt@telecom.at>

Johannes Sixt <johannes.sixt@telecom.at> writes:

> On Monday 10 March 2008 21:42, Johannes Schindelin wrote:
>> For some reason, the construct
>>
>> 	sh -c "$0 \"$@\"" <editor> <file>
>>
>> does not pick up quotes in <editor> as expected.  So replace $0 with
>> <editor>.
>
> No surprise. It must be
>
> 	sh -c '"$0" "$@"' <editor> <file>
>
> Note the extra quotes around $0.

... assuming that there is no dq, $var_reference and other nastiness in
<editor> ;-)