Re: [PATCH] launch_editor(): allow spaces in the filename

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 11, 2008, 00:15 UTC
Message-ID: <7v1w6ii0a1.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LSU.1.00.0803102140280.3975@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 10 quoted lines

> For some reason, the construct
>
> 	sh -c "$0 \"$@\"" <editor> <file>
>
> does not pick up quotes in <editor> as expected.  So replace $0 with
> <editor>.
>
> This fixes
>
> 	git config core.editor "c:/Program Files/What/Ever.exe"

Ah, I misread your patch. The above example needs to be fixed as discussed, but what the patch does to builtin-tag.c is fine.

Show 15 quoted lines

> diff --git a/t/t7005-editor.sh b/t/t7005-editor.sh
> index c1cec55..5395b74 100755
> --- a/t/t7005-editor.sh
> +++ b/t/t7005-editor.sh
> @@ -89,6 +89,34 @@ do
>  	'
>  done
>  
> +test_expect_success 'editor with a space' '
> +
> +	if echo "echo space > \"\$1\"" > "e space.sh"
> +	then
> +		chmod a+x "e space.sh" &&
> +		GIT_EDITOR="./e\ space.sh" \
> +			git --exec-path=. commit --amend &&

Why do you need --exec-path=. to tell the newly built git to find its subcommands from t/trash directory, when you give an explicit instruction to find GIT_EDITOR in "./"?