Re: [PATCH] launch_editor(): allow spaces in the filename

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 10, 2008, 22:18 UTC
Message-ID: <alpine.LSU.1.00.0803102316240.4741@racer.site>
In-Reply-To: <200803102232.13727.johannes.sixt@telecom.at>

Hi,

On Mon, 10 Mar 2008, Johannes Sixt wrote:

Show 22 quoted lines

> On Monday 10 March 2008 21:42, Johannes Schindelin wrote:
> > For some reason, the construct
> >
> > 	sh -c "$0 \"$@\"" <editor> <file>
> >
> > does not pick up quotes in <editor> as expected.  So replace $0 with
> > <editor>.
> 
> No surprise. It must be
> 
> 	sh -c '"$0" "$@"' <editor> <file>
> 
> Note the extra quotes around $0.
> 
> >  			args[i++] = "sh";
> >  			args[i++] = "-c";
> > -			args[i++] = "$0 \"$@\"";
> > +			args[i++] = arg0.buf;
> 
> IOW:
> 
> +			args[i++] = "\"$0\" \"$@\"";

Isn't this wrong? What would this do with a core.editor like this:

[core]
	editor = this-editor --with-this --option

Hmm?

Ciao, Dscho