Re: [PATCH] launch_editor(): allow spaces in the filename

From: Johannes Sixt <johannes.sixt@telecom.at>
Date: Mar 10, 2008, 21:32 UTC
Message-ID: <200803102232.13727.johannes.sixt@telecom.at>
In-Reply-To: <alpine.LSU.1.00.0803102140280.3975@racer.site>

On Monday 10 March 2008 21:42, Johannes Schindelin wrote:

Show 6 quoted lines

> For some reason, the construct
>
> 	sh -c "$0 \"$@\"" <editor> <file>
>
> does not pick up quotes in <editor> as expected.  So replace $0 with
> <editor>.

No surprise. It must be

	sh -c '"$0" "$@"' <editor> <file>

Note the extra quotes around $0.

>  			args[i++] = "sh";
>  			args[i++] = "-c";
> -			args[i++] = "$0 \"$@\"";
> +			args[i++] = arg0.buf;

IOW:

+			args[i++] = "\"$0\" \"$@\"";

-- Hannes