Re: [PATCH v2 24/25] register_ref(): make a copy of the bad reference SHA-1
Michael Haggerty <mhagger@alum.mit.edu> writes:
Show 28 quoted lines
> The lifetime of the sha1 parameter passed to an each_ref_fn callback
> is not guaranteed, so make a copy for later use.
>
> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---
> bisect.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/bisect.c b/bisect.c
> index 374d9e2..71c1958 100644
> --- a/bisect.c
> +++ b/bisect.c
> @@ -15,7 +15,7 @@
> static struct sha1_array good_revs;
> static struct sha1_array skipped_revs;
>
> -static const unsigned char *current_bad_sha1;
> +static unsigned char *current_bad_sha1;
>
> static const char *argv_checkout[] = {"checkout", "-q", NULL, "--", NULL};
> static const char *argv_show_branch[] = {"show-branch", NULL, NULL};
> @@ -404,7 +404,8 @@ static int register_ref(const char *refname, const unsigned char *sha1,
> int flags, void *cb_data)
> {
> if (!strcmp(refname, "bad")) {
> - current_bad_sha1 = sha1;
> + current_bad_sha1 = xmalloc(20);
> + hashcpy(current_bad_sha1, sha1);This, together with 18/25, may hint that we want hashdup()?
> } else if (!prefixcmp(refname, "good-")) {
> sha1_array_append(&good_revs, sha1);
> } else if (!prefixcmp(refname, "skip-")) {Junio C Hamano <gitster@pobox.com>