[PATCH v2 23/25] exclude_existing(): set existing_refs.strdup_strings
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- May 25, 2013, 09:08 UTC
- Message-ID
- <1369472904-12875-24-git-send-email-mhagger@alum.mit.edu>
- In-Reply-To
- <1369472904-12875-1-git-send-email-mhagger@alum.mit.edu>
The each_ref_fn add_existing() adds refnames to the existing_refs list. But the lifetimes of these refnames is not guaranteed by the refs API, so configure the string_list to make copies as it adds them.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> --- builtin/show-ref.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/show-ref.c b/builtin/show-ref.c index 8d9b76a..4a0310d 100644 --- a/builtin/show-ref.c +++ b/builtin/show-ref.c @@ -103,7 +103,7 @@ static int add_existing(const char *refname, const unsigned char *sha1, int flag */ static int exclude_existing(const char *match) { - static struct string_list existing_refs = STRING_LIST_INIT_NODUP; + static struct string_list existing_refs = STRING_LIST_INIT_DUP; char buf[1024]; int matchlen = match ? strlen(match) : 0;
-- 1.8.2.3