Re: [PATCH v2 22/25] string_list_add_refs_by_glob(): add a comment about memory management

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: May 30, 2013, 19:29 UTC
Message-ID: <51A7A88C.2020307@alum.mit.edu>
In-Reply-To: <87ppwaurfy.fsf@linux-k42r.v.cablecom.net>

On 05/29/2013 10:21 AM, Thomas Rast wrote:

Show 17 quoted lines

> Michael Haggerty <mhagger@alum.mit.edu> writes:
> 
>> Since string_list_add_one_ref() adds refname to the string list, but
>> the lifetime of refname is limited, it is important that the
>> string_list passed to string_list_add_one_ref() has strdup_strings
>> set.  Document this fact.
>>
>> All current callers do the right thing.
> [...]
>> +/*
>> + * The list argument must have strdup_strings set on it.
>> + */
>>  void string_list_add_refs_by_glob(struct string_list *list, const char *glob)
>>  {
>>  	if (has_glob_specials(glob)) {
> 
> Maybe add an assert() so that this is bulletproof?

Good idea.  Will be added in v3.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/