Re: [PATCH v2 FIXUP 22/25] fixup! string_list_add_refs_by_glob(): add a comment about memory management

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 3, 2013, 15:31 UTC
Message-ID: <7vfvwzjjmy.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1369951551-25662-1-git-send-email-mhagger@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---
> Junio, would you mind squashing this patch onto mh/reflife 22/25?

Done.  Thanks.

Show 16 quoted lines

>
>  notes.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/notes.c b/notes.c
> index 602d956..b69c0b8 100644
> --- a/notes.c
> +++ b/notes.c
> @@ -932,6 +932,7 @@ static int string_list_add_one_ref(const char *refname, const unsigned char *sha
>   */
>  void string_list_add_refs_by_glob(struct string_list *list, const char *glob)
>  {
> +	assert(list->strdup_strings);
>  	if (has_glob_specials(glob)) {
>  		for_each_glob_ref(string_list_add_one_ref, glob, list);
>  	} else {