[PATCH v2 03/25] add_rev_cmdline(): make a copy of the name argument
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- May 25, 2013, 09:08 UTC
- Message-ID
- <1369472904-12875-4-git-send-email-mhagger@alum.mit.edu>
- In-Reply-To
- <1369472904-12875-1-git-send-email-mhagger@alum.mit.edu>
Instead of assuming that the memory pointed to by the name argument will live forever, make a local copy of it before storing it in the ref_cmdline_info.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> --- revision.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/revision.c b/revision.c index a67b615..25e424c 100644 --- a/revision.c +++ b/revision.c @@ -898,6 +898,10 @@ static int limit_list(struct rev_info *revs) return 0; } +/* + * Add an entry to refs->cmdline with the specified information. + * *name is copied. + */ static void add_rev_cmdline(struct rev_info *revs, struct object *item, const char *name, @@ -909,7 +913,7 @@ static void add_rev_cmdline(struct rev_info *revs, ALLOC_GROW(info->rev, nr + 1, info->alloc); info->rev[nr].item = item; - info->rev[nr].name = name; + info->rev[nr].name = xstrdup(name); info->rev[nr].whence = whence; info->rev[nr].flags = flags; info->nr++;
-- 1.8.2.3