git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb.js: Harden setting blamed commit info in incremental blame

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 25, 2009, 21:39 UTC
Message-ID
<7vd436s2r8.fsf@alter.siamese.dyndns.org>
In-Reply-To
<200911252155.59318.jnareb@gmail.com>
Jakub Narebski <jnareb@gmail.com> writes:
> It was 'Unspecified error.' shown in xhr watch.  Accessing xhr.status
> causes an error.

As to the topic, it does not seem to break _existing_ features; if that is not the case, please let me know.

Otherwise I'm inclined to merge the entire series to 'master' by 1.6.6-rc1.
    6821dee gitweb.js: fix padLeftStr() and its usage
    6aa2de5 gitweb.js: Harden setting blamed commit info in incremental blame
    e42a05f gitweb.js: fix null object exception in initials calculation
    63267de gitweb: Minify gitweb.js if JSMIN is defined
    c4ccf61 gitweb: Create links leading to 'blame_incremental' using JavaScript
    e206d62 gitweb: Colorize 'blame_incremental' view during processing
    4af819d gitweb: Incremental blame (using JavaScript)
    aa7dd05 gitweb: Add optional "time to generate page" info in footer
    -aef3768 gitweb: Use light/dark for class names also in 'blame' view

and treat it as a new feature with known breakages, to give it wider audience. That way you will hopefully get more people who are willing to help debug/fix things for you.

Previous: Jakub NarebskiNext: Jakub Narebski
Message 20 of 41 in “jn/gitweb-blame fixes”
  1. 0/2 jn/gitweb-blame fixesStephen Boyd, Nov 19, 2009
  2. 1/2 gitweb.js: fix null object exception in initials calculationStephen Boyd, Nov 19, 2009
  3. Jakub NarebskiNov 19, 2009
  4. Stephen BoydNov 19, 2009
  5. 2/2 gitweb.js: use unicode encoding for nbsp instead of html entityStephen Boyd, Nov 19, 2009
  6. Jakub NarebskiNov 19, 2009
  7. Stephen BoydNov 20, 2009
  8. 2/2 gitweb.js: fix padLeftStr() and its usageStephen Boyd, Nov 25, 2009
  9. Jakub NarebskiNov 19, 2009
  10. Stephen BoydNov 20, 2009
  11. Stephen BoydNov 20, 2009
  12. Jakub NarebskiNov 21, 2009
  13. Jakub NarebskiNov 21, 2009
  14. gitweb.js: Harden setting blamed commit info in incremental blameJakub Narebski, Nov 25, 2009
  15. Nanako ShiraishiNov 25, 2009
  16. Jakub NarebskiNov 25, 2009
  17. Stephen BoydNov 25, 2009
  18. Jakub NarebskiNov 25, 2009
  19. Jakub NarebskiNov 25, 2009
  20. Junio C HamanoNov 25, 2009
  21. Jakub NarebskiNov 25, 2009
  22. Junio C HamanoNov 26, 2009
  23. Jakub NarebskiNov 26, 2009
  24. gitweb: Make linking to actions requiring JavaScript a featureJakub Narebski, Nov 26, 2009
  25. Junio C HamanoNov 26, 2009
  26. Jakub NarebskiNov 26, 2009
  27. Junio C HamanoNov 27, 2009
  28. Jakub NarebskiNov 27, 2009
  29. Junio C HamanoNov 27, 2009
  30. Junio C HamanoDec 1, 2009
  31. Jakub NarebskiDec 1, 2009
  32. 1/2 gitweb: Make linking to actions requiring JavaScript a featureJakub Narebski, Dec 1, 2009
  33. 2/2 gitweb: Add link to other blame implementation in blame viewsJakub Narebski, Dec 1, 2009
  34. Stephen BoydDec 7, 2009
  35. Stephen BoydDec 7, 2009
  36. PATCH/RFC] gitweb.js: Workaround for IE8 bugJakub Narebski, Dec 8, 2009
  37. Stephen BoydDec 8, 2009
  38. Jakub NarebskiDec 8, 2009
  39. Jakub NarebskiDec 8, 2009
  40. Stephen BoydDec 9, 2009
  41. Stephen BoydNov 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.