git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: PATCH/RFC] gitweb.js: Workaround for IE8 bug

From
Jakub Narebski <jnareb@gmail.com>
Date
Dec 8, 2009, 22:24 UTC
Message-ID
<200912082324.49825.jnareb@gmail.com>
In-Reply-To
<1260309382.5658.41.camel@swboyd-laptop>
On Tue, 8 Dec 2009, Stephen Boyd wrote:
Show 8 quoted lines
> On Tue, 2009-12-08 at 17:29 +0100, Jakub Narebski wrote: 
> > 
> > Does the following fixes the issue for IE8 for you (it works for me)?
> > 
> 
> Yes, there is no longer an error but IE8 still locks up and takes about
> 30 seconds. It doesn't seem to be any more responsive. Isn't putting the
> error in a try-catch just papering over the issue?
Well, I wrote it is *workaround* for IE8 bug, didn't I?

There are actually two separate issues. First is 'blame_incremental' freezing browser (making it non responsive), second is proper solution to this bug.

The problem with 'blame_incremental' freezing is that JavaScript is
single-threaded, and that modifying DOM is not lightweight.  gitweb.js
should then use technique described in
  http://www.nczonline.net/blog/2009/08/11/timed-array-processing-in-javascript/
to avoid freezing browser, and perhaps also some technique to avoid
reflowing (if possible).

The proper solution for IE8 bug would be to use 'progress', 'error' and 'load' events of XHR 2.0 (XMLHttpRequest specification level 2) if they are available, instead of mucking with underspecified 'readystatechange' event from XHR 1.0 and timer. But it is a more complicated solution.

-- 
Jakub Narebski
Poland
Previous: Stephen BoydNext: Jakub Narebski
Message 38 of 41 in “jn/gitweb-blame fixes”
  1. 0/2 jn/gitweb-blame fixesStephen Boyd, Nov 19, 2009
  2. 1/2 gitweb.js: fix null object exception in initials calculationStephen Boyd, Nov 19, 2009
  3. Jakub NarebskiNov 19, 2009
  4. Stephen BoydNov 19, 2009
  5. 2/2 gitweb.js: use unicode encoding for nbsp instead of html entityStephen Boyd, Nov 19, 2009
  6. Jakub NarebskiNov 19, 2009
  7. Stephen BoydNov 20, 2009
  8. 2/2 gitweb.js: fix padLeftStr() and its usageStephen Boyd, Nov 25, 2009
  9. Jakub NarebskiNov 19, 2009
  10. Stephen BoydNov 20, 2009
  11. Stephen BoydNov 20, 2009
  12. Jakub NarebskiNov 21, 2009
  13. Jakub NarebskiNov 21, 2009
  14. gitweb.js: Harden setting blamed commit info in incremental blameJakub Narebski, Nov 25, 2009
  15. Nanako ShiraishiNov 25, 2009
  16. Jakub NarebskiNov 25, 2009
  17. Stephen BoydNov 25, 2009
  18. Jakub NarebskiNov 25, 2009
  19. Jakub NarebskiNov 25, 2009
  20. Junio C HamanoNov 25, 2009
  21. Jakub NarebskiNov 25, 2009
  22. Junio C HamanoNov 26, 2009
  23. Jakub NarebskiNov 26, 2009
  24. gitweb: Make linking to actions requiring JavaScript a featureJakub Narebski, Nov 26, 2009
  25. Junio C HamanoNov 26, 2009
  26. Jakub NarebskiNov 26, 2009
  27. Junio C HamanoNov 27, 2009
  28. Jakub NarebskiNov 27, 2009
  29. Junio C HamanoNov 27, 2009
  30. Junio C HamanoDec 1, 2009
  31. Jakub NarebskiDec 1, 2009
  32. 1/2 gitweb: Make linking to actions requiring JavaScript a featureJakub Narebski, Dec 1, 2009
  33. 2/2 gitweb: Add link to other blame implementation in blame viewsJakub Narebski, Dec 1, 2009
  34. Stephen BoydDec 7, 2009
  35. Stephen BoydDec 7, 2009
  36. PATCH/RFC] gitweb.js: Workaround for IE8 bugJakub Narebski, Dec 8, 2009
  37. Stephen BoydDec 8, 2009
  38. Jakub NarebskiDec 8, 2009
  39. Jakub NarebskiDec 8, 2009
  40. Stephen BoydDec 9, 2009
  41. Stephen BoydNov 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.