Re: [PATCH 0/2] jn/gitweb-blame fixes
On Sat, 21 Nov 2009, Jakub Narebski wrote:
Show 14 quoted lines
> * Testing it with IE8 (Internet Explorer 8.0.6001.18702) page loading stops
> at 0%, at the very beginning on startBlame() function
>
> IE8 shows that it finds the following errors:
>
> * "firstChild is null or not an object"
> line: 565, char:4
>
> a_sha1.firstChild.data = commit.sha1.substr(0, 8);
>
> It might be caused by the fact that firstChild for this case should be
> text node containing of pure whitespace:
> <a href=""> </a>
> Perhaps IE8 simplifies it in "compatibility view" mode
This bug (be it in gitweb.js or in IE8) is fixed by the following patch:
-- 8< --
diff --git i/gitweb/gitweb.js w/gitweb/gitweb.js
index 200ec5a..c1e425c 100644
--- i/gitweb/gitweb.js
+++ w/gitweb/gitweb.js
@@ -562,7 +562,12 @@ function handleLine(commit, group) {
td_sha1.rowSpan = group.numlines;
a_sha1.href = projectUrl + 'a=commit;h=' + commit.sha1;
- a_sha1.firstChild.data = commit.sha1.substr(0, 8);
+ if (a_sha1.firstChild) {
+ a_sha1.firstChild.data = commit.sha1.substr(0, 8);
+ } else {
+ a_sha1.appendChild(
+ document.createTextNode(commit.sha1.substr(0, 8)));
+ }
if (group.numlines >= 2) {
var fragment = document.createDocumentFragment();
var br = document.createElement("br");
-- >8 --
>
> * "Unspecified error" (twice)
> line: 777, char:2
>
> if (xhr.readyState === 3 && xhr.status !== 200) {
> return;
> }
>
> I don't know what might be the source of error here; I suspect that the
> error position mentioned by IE8 is bogus.
But I have no idea how to fix this. "Unspecified error" isn't very
helpful...
--
Jakub Narebski
Poland
Jakub Narebski <jnareb@gmail.com>