PATCH/RFC] gitweb.js: Workaround for IE8 bug
- From
Jakub Narebski <jnareb@gmail.com>
- Date
- Dec 8, 2009, 16:29 UTC
- Message-ID
- <200912081729.11890.jnareb@gmail.com>
- In-Reply-To
- <1260148741.1579.50.camel@swboyd-laptop>
On Mon, 7 Dec 2009, Stephen Boyd wrote:
Show 8 quoted lines
> On Sun, 2009-12-06 at 17:04 -0800, Stephen Boyd wrote: > > > > Ok. It's December and I've had some more time to look into this. > > Initializing 'xhr' to null seems to get rid of the "Unknown error" > > problem (see patch below). > > > > Ah sorry. Seems this doesn't work and I was just getting lucky.
Does the following fixes the issue for IE8 for you (it works for me)?
As for testing, try with blaming 'revision.c' and 'gitweb/gitweb.perl' using 'blame_incremental' view.
With probably too long commit message, and not detailed enough title:
-- >8 -- Subject: [PATCH] gitweb.js: Workaround for IE8 bug
In Internet Explorer 8 (IE8) the 'blame_incremental' view, which uses JavaScript to generate blame info using AJAX, sometimes hang at the beginning (at 0%) of blaming, e.g. for larger files with long history like git's own gitweb/gitweb.perl.
The error shown by JavaScript console is "Unspecified error" at char:2 of the following line in gitweb/gitweb.js:
if (xhr.readyState === 3 && xhr.status !== 200) {Debugging it using IE8 JScript debuger shown that the error occurs when trying to access xhr.status (xhr is XMLHttpRequest object). Watch for xhr object shows 'Unspecified error.' as "value" of xhr.status, and trying to access xhr.status from console throws error.
This bug is some intermittent bug, depending on XMLHttpRequest timing, as it doesn't occur in all cases. It is probably caused by the fact that handleResponse is called from timer (pollTimer), to work around the fact that some browsers call onreadystatechange handler only once for each state change, and not like required for 'blame_incremental' as soon as new data is available from server. It looks like xhr object is not properly initialized; still it is a bug to throw an error when accessing xhr.status (and not use 'null' or 'undefined' as value).
Work around this bug in IE8 by using try-catch block when accessing xhr.status.
Signed-off-by: Jakub Narebski <jnareb@gmail.com> --- gitweb/gitweb.js | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.js b/gitweb/gitweb.js index 2a25b7c..9c66928 100644 --- a/gitweb/gitweb.js +++ b/gitweb/gitweb.js @@ -779,7 +779,12 @@ function handleResponse() { } // the server returned error - if (xhr.readyState === 3 && xhr.status !== 200) { + // try ... catch block is to work around bug in IE8 + try { + if (xhr.readyState === 3 && xhr.status !== 200) { + return; + } + } catch (e) { return; } if (xhr.readyState === 4 && xhr.status !== 200) {
-- 1.6.5.3