Re: [PATCH] gitweb.js: Harden setting blamed commit info in incremental blame
- From
Stephen Boyd <bebarino@gmail.com>
- Date
- Dec 7, 2009, 01:04 UTC
- Message-ID
- <1260147860.1579.47.camel@swboyd-laptop>
- In-Reply-To
- <200911251536.08993.jnareb@gmail.com>
On Wed, 2009-11-25 at 15:36 +0100, Jakub Narebski wrote:
Show 13 quoted lines
> Well, the one time I was able to run debugger (F12, select 'Script', select
> 'gitweb.js') with error occurring and without IE hanging (for README file)
> it did show an error for the following line:
>
> if (xhr.readyState === 3 && xhr.status !== 200) {
>
> When I checked 'xhr' object, it has "Unknown error" as contents of
> xhr.statusText field and as contents of xhr.status (sic!), which should
> be a number: HTTP status code.
>
> Unfortunately I had to take a break... and I was not able to reproduce this
> (without hanging web browser: "program not responding") since then...
> Ok. It's December and I've had some more time to look into this. Initializing 'xhr' to null seems to get rid of the "Unknown error" problem (see patch below).
The responsiveness on IE8 is pretty poor. I load the page and then after some waiting (usually 20-30 seconds including IE becoming a "Not Responding" program) the whole page will load. There is nothing incremental about it. I'm trying to figure out why it's slow now.
--->8----
Subject: [PATCH] gitweb.js: workaround IE8 "Unknown error"
Internet Explorer 8 complains about an "Unknown error on line 782, char 2". That line is a reference to xhr and the status code. By initializing xhr to null this error goes away.
Signed-off-by: Stephen Boyd <bebarino@gmail.com> --- gitweb/gitweb.js | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.js b/gitweb/gitweb.js index 2a25b7c..b936635 100644 --- a/gitweb/gitweb.js +++ b/gitweb/gitweb.js @@ -126,7 +126,7 @@ function createRequestObject() { /* ============================================================ */ /* utility/helper functions (and variables) */ -var xhr; // XMLHttpRequest object +var xhr = null; // XMLHttpRequest object var projectUrl; // partial query + separator ('?' or ';') // 'commits' is an associative map. It maps SHA1s to Commit objects.
-- 1.6.6.rc1.39.g9a42