Re: [PATCH 0/2] jn/gitweb-blame fixes
- From
Stephen Boyd <bebarino@gmail.com>
- Date
- Nov 23, 2009, 04:52 UTC
- Message-ID
- <4B0A14F6.5080405@gmail.com>
- In-Reply-To
- <200911210132.44649.jnareb@gmail.com>
Jakub Narebski wrote:
Show 7 quoted lines
> I have tested gitweb with both of your patches applied, serving gitweb > as CGI script using Apache 2.0.54 on Linux, and viewing from separate > computer on MS Windows XP, with the following results: > > * For the following browsers blame_incremental view on gitweb/gitweb.perl > file produces correct output, but for progress info which instead of > ( 1%) -> ( 29%) -> (100%) looks more like ( 1%) -> (29%) -> (100%)
This is due to an off-by-one error in the while loop. This should fix it. I'll probably squash this into patch 2 and resend.
--->8----
diff --git a/gitweb/gitweb.js b/gitweb/gitweb.js index 30597dd..9214497 100644 --- a/gitweb/gitweb.js +++ b/gitweb/gitweb.js @@ -43,7 +43,7 @@ function padLeftStr(input, width, str) { var prefix = ''; width -= input.toString().length; - while (width > 1) { + while (width > 0) { prefix += str; width--; }