git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH next] git-notes: fix printing of multi-line notes

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 14, 2009, 06:48 UTC
Message-ID
<7v3afm758u.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.DEB.1.00.0901132339270.3586@pacific.mpi-cbg.de>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 17 quoted lines
> On Tue, 13 Jan 2009, Tor Arne Vestbø wrote:
>
>> The line length was read from the same position every time,
>> causing mangled output when printing notes with multiple lines.
>> 
>> Also, adding new-line manually for each line ensures that we
>> get a new-line between commits, matching git-log for commits
>> without notes.
>> 
>> Signed-off-by: Tor Arne Vestbø <tavestbo@trolltech.com>
>> ---
>
> Patch looks good, so 
>
> Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> For extra browny points, you could add a test with multi-line notes.

Yeah, not just "extra", having tests is a good way to make sure a new feature like this evolves healthily.

Tor?
Previous: Johannes SchindelinNext: Johannes Schindelin
Message 3 of 17 in “git-notes: fix printing of multi-line notes”
  1. git-notes: fix printing of multi-line notesTor Arne Vestbø, Jan 13, 2009
  2. Johannes SchindelinJan 13, 2009
  3. Junio C HamanoJan 14, 2009
  4. Johannes SchindelinJan 14, 2009
  5. git-notes: add test case for multi-line notesTor Arne Vestbø, Jan 14, 2009
  6. Johannes SchindelinJan 14, 2009
  7. git-notes: add test case for multi-line notesTor Arne Vestbø, Jan 14, 2009
  8. Jeff KingJan 14, 2009
  9. Boyd Stephen Smith Jr.Jan 14, 2009
  10. Jeff KingJan 14, 2009
  11. Johannes SixtJan 14, 2009
  12. Jeff KingJan 14, 2009
  13. Johannes SchindelinJan 14, 2009
  14. git-notes: add test case for multi-line notesTor Arne Vestbø, Jan 14, 2009
  15. Johannes SchindelinJan 14, 2009
  16. git-notes: fix printing of multi-line notesTor Arne Vestbø, Jan 16, 2009
  17. Junio C HamanoJan 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.