Re: [PATCH next] git-notes: fix printing of multi-line notes

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 13, 2009, 22:40 UTC
Message-ID: <alpine.DEB.1.00.0901132339270.3586@pacific.mpi-cbg.de>
In-Reply-To: <496CF21C.2050500@trolltech.com>

Hi,

On Tue, 13 Jan 2009, Tor Arne Vestbø wrote:

Show 9 quoted lines

> The line length was read from the same position every time,
> causing mangled output when printing notes with multiple lines.
> 
> Also, adding new-line manually for each line ensures that we
> get a new-line between commits, matching git-log for commits
> without notes.
> 
> Signed-off-by: Tor Arne Vestbø <tavestbo@trolltech.com>
> ---

Patch looks good, so

Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>

For extra browny points, you could add a test with multi-line notes.

Ciao, Dscho