git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH next v2] git-notes: add test case for multi-line notes

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Jan 14, 2009, 17:14 UTC
Message-ID
<496E1D77.6000307@viscovery.net>
In-Reply-To
<20090114165633.GC15758@coredump.intra.peff.net>
Jeff King schrieb:
Show 9 quoted lines
> On Wed, Jan 14, 2009 at 05:28:11PM +0100, Tor Arne Vestbø wrote:
> 
>> +MSG=${MSG//%/}
>> +printf "$MSG" > "$1"
>> +printf "$MSG" >& 2
> 
> Substitution parameter expansion is a bash-ism, IIRC. How about just
> 
>   printf %s "$MSG" ?

A the point was that $MSG contains \n, which should be turned int LF. IMO, the easiest way to achieve this is:

MSG='b3 c3c3c3c3 d3d3d3'

test_expect_success ' ... ' '
   ...
   MSG="$MSG" git notes edit
'
and go back to using echo in the part cited above.
-- Hannes
Previous: Jeff KingNext: Jeff King
Message 11 of 17 in “git-notes: fix printing of multi-line notes”
  1. git-notes: fix printing of multi-line notesTor Arne Vestbø, Jan 13, 2009
  2. Johannes SchindelinJan 13, 2009
  3. Junio C HamanoJan 14, 2009
  4. Johannes SchindelinJan 14, 2009
  5. git-notes: add test case for multi-line notesTor Arne Vestbø, Jan 14, 2009
  6. Johannes SchindelinJan 14, 2009
  7. git-notes: add test case for multi-line notesTor Arne Vestbø, Jan 14, 2009
  8. Jeff KingJan 14, 2009
  9. Boyd Stephen Smith Jr.Jan 14, 2009
  10. Jeff KingJan 14, 2009
  11. Johannes SixtJan 14, 2009
  12. Jeff KingJan 14, 2009
  13. Johannes SchindelinJan 14, 2009
  14. git-notes: add test case for multi-line notesTor Arne Vestbø, Jan 14, 2009
  15. Johannes SchindelinJan 14, 2009
  16. git-notes: fix printing of multi-line notesTor Arne Vestbø, Jan 16, 2009
  17. Junio C HamanoJan 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.