From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 14 Jan 2009 06:48:17 GMT
Subject: Re: [PATCH next] git-notes: fix printing of multi-line notes
Message-ID: <7v3afm758u.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.1.00.0901132339270.3586@pacific.mpi-cbg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> On Tue, 13 Jan 2009, Tor Arne Vestbø wrote:
>
>> The line length was read from the same position every time,
>> causing mangled output when printing notes with multiple lines.
>> 
>> Also, adding new-line manually for each line ensures that we
>> get a new-line between commits, matching git-log for commits
>> without notes.
>> 
>> Signed-off-by: Tor Arne Vestbø <tavestbo@trolltech.com>
>> ---
>
> Patch looks good, so 
>
> Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> For extra browny points, you could add a test with multi-line notes.

Yeah, not just "extra", having tests is a good way to make sure a new
feature like this evolves healthily.

Tor?