Re: [PATCH next] git-notes: fix printing of multi-line notes
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 14, 2009, 10:14 UTC
- Message-ID
- <alpine.DEB.1.00.0901141113250.3586@pacific.mpi-cbg.de>
- In-Reply-To
- <7v3afm758u.fsf@gitster.siamese.dyndns.org>
Hi,
On Tue, 13 Jan 2009, Junio C Hamano wrote:
Show 22 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > On Tue, 13 Jan 2009, Tor Arne Vestbø wrote: > > > >> The line length was read from the same position every time, > >> causing mangled output when printing notes with multiple lines. > >> > >> Also, adding new-line manually for each line ensures that we > >> get a new-line between commits, matching git-log for commits > >> without notes. > >> > >> Signed-off-by: Tor Arne Vestbø <tavestbo@trolltech.com> > >> --- > > > > Patch looks good, so > > > > Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de> > > > > For extra browny points, you could add a test with multi-line notes. > > Yeah, not just "extra", having tests is a good way to make sure a new > feature like this evolves healthily.
Oh, and of course I meant "brownie"...
Ducks, Dscho