git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH next v2] git-notes: add test case for multi-line notes

From
Jeff King <peff@peff.net>
Date
Jan 14, 2009, 17:13 UTC
Message-ID
<20090114171315.GA16063@coredump.intra.peff.net>
In-Reply-To
<200901141109.56580.bss@iguanasuicide.net>
On Wed, Jan 14, 2009 at 11:09:52AM -0600, Boyd Stephen Smith Jr. wrote:
Show 8 quoted lines
> >  printf %s "$MSG" ?
> 
> On my box
> $ printf '%s\n' '\n'
> \n
> $
> 
> He wants '\n' in $MSG to be expanded, and what you gave doesn't do that.
Oh, sorry. That's what I get for not reading his patch carefully.

It looks like all of the input is statically included in the test script. While I think it is nice to be defensive, it is probably simplest to just assume there is no '%' in this case (which we can verify by reading the script).

-Peff
Previous: Boyd Stephen Smith Jr.Next: Johannes Sixt
Message 10 of 17 in “git-notes: fix printing of multi-line notes”
  1. git-notes: fix printing of multi-line notesTor Arne Vestbø, Jan 13, 2009
  2. Johannes SchindelinJan 13, 2009
  3. Junio C HamanoJan 14, 2009
  4. Johannes SchindelinJan 14, 2009
  5. git-notes: add test case for multi-line notesTor Arne Vestbø, Jan 14, 2009
  6. Johannes SchindelinJan 14, 2009
  7. git-notes: add test case for multi-line notesTor Arne Vestbø, Jan 14, 2009
  8. Jeff KingJan 14, 2009
  9. Boyd Stephen Smith Jr.Jan 14, 2009
  10. Jeff KingJan 14, 2009
  11. Johannes SixtJan 14, 2009
  12. Jeff KingJan 14, 2009
  13. Johannes SchindelinJan 14, 2009
  14. git-notes: add test case for multi-line notesTor Arne Vestbø, Jan 14, 2009
  15. Johannes SchindelinJan 14, 2009
  16. git-notes: fix printing of multi-line notesTor Arne Vestbø, Jan 16, 2009
  17. Junio C HamanoJan 18, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.