git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Support Out-Of-Tree Valgrind Tests

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 6, 2012, 23:12 UTC
Message-ID
<7v399lqq7x.fsf@alter.siamese.dyndns.org>
In-Reply-To
<87mx7te3ng.fsf@smith.obbligato.org>
"David A. Greene" <dag@cray.com> writes:
> Ok, I see.  So TEST_DIRECTORY is supposed to point to the "official"
> location of git's tests and testing support files.  That wasn't clear to
> me.

That is how I read the intent of what test-lib.sh does. I do not think it has much to do with official-ness, but more about where you find pieces of the framework from (e.g. diff-lib.sh, lib-gpg.sh, etc.)

> I think naming is a big issue here.  Perhaps TEST_DIRECTORY needs a
> better name, something like GIT_TEST_SUPPORT or such?

I do not think so; the biggest problem I see is that nobody documented these variables like Thomas did in the previous message we saw in this thread (and Thomas knew more about them than all because he added t/perf/ recently and had to play with these variables).

Once the roles of variables are well understood, I do not think it is worth renaming the existing uses.

Previous: David A. GreeneNext: David A. Greene
Message 12 of 18 in “Allow Overriding GIT_BUILD_DIR”
  1. 1/2 Allow Overriding GIT_BUILD_DIRgreened@obbligato.org, Mar 4, 2012
  2. 2/2 Support Out-Of-Tree Valgrind Testsgreened@obbligato.org, Mar 4, 2012
  3. Thomas RastMar 5, 2012
  4. David A. GreeneMar 5, 2012
  5. Thomas RastMar 6, 2012
  6. David A. GreeneMar 6, 2012
  7. Junio C HamanoMar 6, 2012
  8. David A. GreeneMar 6, 2012
  9. Junio C HamanoMar 6, 2012
  10. Junio C HamanoMar 6, 2012
  11. David A. GreeneMar 6, 2012
  12. Junio C HamanoMar 6, 2012
  13. David A. GreeneMar 6, 2012
  14. Junio C HamanoMar 6, 2012
  15. Junio C HamanoMar 5, 2012
  16. David A. GreeneMar 5, 2012
  17. Junio C HamanoMar 5, 2012
  18. David A. GreeneMar 6, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.