Re: [PATCH 2/2] Support Out-Of-Tree Valgrind Tests
- From
Thomas Rast <trast@inf.ethz.ch>
- Date
- Mar 5, 2012, 07:53 UTC
- Message-ID
- <87aa3vzdoc.fsf@thomas.inf.ethz.ch>
- In-Reply-To
- <1330903437-31386-2-git-send-email-greened@obbligato.org>
greened@obbligato.org writes:
Show 13 quoted lines
> +# GIT_VALGRIND_TOOLS is the location of tools like valgrind.sh. > +if test -z "$GIT_VALGRIND_TOOLS" > +then > + # We allow tests to override this, in case they want to run tests > + # outside of t/. > + > + # For in-tree test scripts, this is in TEST_DIRECTORY/valgrind > + # (t/valgrind), but a test script that lives outside t/ can > + # set this variable to point at the right place so that it can > + # find t/valgrind directory that house test helpers like > + # valgrind.sh. > + GIT_VALGRIND_TOOLS="$TEST_DIRECTORY"/valgrind > +fi
I'm a bit curious: why isn't it enough to spell that path $GIT_BUILD_DIR/t/valgrind instead of making it fully configurable?
--
Thomas Rast
trast@{inf,student}.ethz.ch