Re: [PATCH 2/2] Support Out-Of-Tree Valgrind Tests
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 6, 2012, 18:43 UTC
- Message-ID
- <7veht5tvsi.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <878vje86cy.fsf@thomas.inf.ethz.ch>
Thomas Rast <trast@inf.ethz.ch> writes:
Show 23 quoted lines
> Don't we, right now, get stuff as follows: > > item path > -------------------------------------------- > test-lib.sh $TEST_DIRECTORY > git $GIT_BUILD_DIR/bin-wrappers > valgrind.sh $TEST_DIRECTORY/valgrind > git (with --valgrind) $TEST_DIRECTORY/valgrind/bin > > You are saying this must change to an entirely new path > > valgrind.sh $GIT_VALGRIND_TOOLS > git (with --valgrind) $GIT_VALGRIND_TOOLS/bin > > but what's wrong with simply > > valgrind.sh $GIT_BUILD_DIR/t/valgrind > git (with --valgrind) $TEST_DIRECTORY/valgrind/bin > > In the common case of t/, these just map to what we had before. In the > out-of-tree case, we'd create valgrind/bin in the test directory for the > *temporary* stuff, and still look for the wrapping valgrind.sh in the > git tree.
Sounds sane. Simple is good.
No matter what happens to this particular patch, could we have the above table (the final version of it, that is) in t/README or something, please?
Thanks.