git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] Allow Overriding GIT_BUILD_DIR

From
greened@obbligato.org <greened@obbligato.org>
Date
Mar 4, 2012, 23:23 UTC
Message-ID
<1330903437-31386-1-git-send-email-greened@obbligato.org>
From: "David A. Greene" <greened@obbligato.org>

Let tests override GIT_BUILD_DIR so git will work if tests are not at the same directory level as standard git tests. Prior to this change, GIT_BUILD_DIR is hardwired to be exactly one directory above where the test lives. A test within contrib/, for example, can now use test-lib.sh and set an appropriate value for GIT_BUILD_DIR.

Signed-off-by: David A. Greene <greened@obbligato.org>
---
 t/test-lib.sh |   16 +++++++++++++++-
 1 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index a65dfc7..cb3a0a2 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -55,6 +55,7 @@ unset $(perl -e '
 		.*_TEST
 		PROVE
 		VALGRIND
+                BUILD_DIR
 	));
 	my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);
 	print join("\n", @vars);
@@ -901,7 +902,20 @@ then
 	# itself.
 	TEST_DIRECTORY=$(pwd)
 fi
-GIT_BUILD_DIR="$TEST_DIRECTORY"/..
+
+if test -z "$GIT_BUILD_DIR"
+then
+	# We allow tests to override this, in case they want to run tests
+	# outside of t/.
+ 
+        # For in-tree test scripts, this is one level above the
+        # TEST_DIRECTORY (t/), but a test script that lives outside t/
+        # can set this variable to point at the right place so that it
+        # can find t/ directory that house test helpers like
+        # lib-pager*.sh and test vectors like t4013/ as well as
+        # previously built git tools.
+       GIT_BUILD_DIR="$TEST_DIRECTORY"/..
+fi
 
 if test -n "$valgrind"
 then
-- 
1.7.9.1
Next: greened@obbligato.org
Message 1 of 18 in “Allow Overriding GIT_BUILD_DIR”
  1. 1/2 Allow Overriding GIT_BUILD_DIRgreened@obbligato.org, Mar 4, 2012
  2. 2/2 Support Out-Of-Tree Valgrind Testsgreened@obbligato.org, Mar 4, 2012
  3. Thomas RastMar 5, 2012
  4. David A. GreeneMar 5, 2012
  5. Thomas RastMar 6, 2012
  6. David A. GreeneMar 6, 2012
  7. Junio C HamanoMar 6, 2012
  8. David A. GreeneMar 6, 2012
  9. Junio C HamanoMar 6, 2012
  10. Junio C HamanoMar 6, 2012
  11. David A. GreeneMar 6, 2012
  12. Junio C HamanoMar 6, 2012
  13. David A. GreeneMar 6, 2012
  14. Junio C HamanoMar 6, 2012
  15. Junio C HamanoMar 5, 2012
  16. David A. GreeneMar 5, 2012
  17. Junio C HamanoMar 5, 2012
  18. David A. GreeneMar 6, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.