Re: [PATCH 2/2] Support Out-Of-Tree Valgrind Tests

From: David A. Greene <dag@cray.com>
Date: Mar 5, 2012, 18:11 UTC
Message-ID: <nngy5re29zn.fsf@transit.us.cray.com>
In-Reply-To: <87aa3vzdoc.fsf@thomas.inf.ethz.ch>

Thomas Rast <trast@inf.ethz.ch> writes:

Show 18 quoted lines

> greened@obbligato.org writes:
>
>> +# GIT_VALGRIND_TOOLS is the location of tools like valgrind.sh.
>> +if test -z "$GIT_VALGRIND_TOOLS"
>> +then
>> +	# We allow tests to override this, in case they want to run tests
>> +	# outside of t/.
>> + 
>> +        # For in-tree test scripts, this is in TEST_DIRECTORY/valgrind
>> +        # (t/valgrind), but a test script that lives outside t/ can
>> +        # set this variable to point at the right place so that it can
>> +        # find t/valgrind directory that house test helpers like
>> +        # valgrind.sh.
>> +       GIT_VALGRIND_TOOLS="$TEST_DIRECTORY"/valgrind
>> +fi
>
> I'm a bit curious: why isn't it enough to spell that path
> $GIT_BUILD_DIR/t/valgrind instead of making it fully configurable?

For the same reason that TEST_DIRECTORY is different and unrelated from GIT_BUILD_DIR. It's my understanding that GIT_BUILD_DIR could end up being somewhere compeltely unrelated to where TOP_SRC/t/valgrind is. At least that's why I introduced a new parameter.

                           -Dave