git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] send-email: new 'add-envelope' option

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 22, 2009, 02:58 UTC
Message-ID
<7v1vjrmfjw.fsf@alter.siamese.dyndns.org>
In-Reply-To
<94a0d4530911211159l1fadad0ldb0d760439ceb57@mail.gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
> There are no tests for 'envelope-sender', so I don't think it should
> be a requirement for this patch to do so....

The fact that the lack of test was pointed out as a problem makes it a requirement. Others' earlier mistakes are not an excuse for you to do a poor job.

I do use --envelope-sender when sending patches out via msmtp. What wonderful things this patch adds am I missing in my current setup?

Previous: Felipe ContrerasNext: Felipe Contreras
Message 4 of 11 in “send-email: new 'add-envelope' option”
  1. send-email: new 'add-envelope' optionFelipe Contreras, Nov 21, 2009
  2. Jeff KingNov 21, 2009
  3. Felipe ContrerasNov 21, 2009
  4. Junio C HamanoNov 22, 2009
  5. Felipe ContrerasNov 22, 2009
  6. Junio C HamanoNov 22, 2009
  7. Junio C HamanoNov 22, 2009
  8. Felipe ContrerasNov 23, 2009
  9. Felipe ContrerasNov 22, 2009
  10. Junio C HamanoNov 22, 2009
  11. Felipe ContrerasNov 24, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.