From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 22 Nov 2009 02:58:11 GMT
Subject: Re: [PATCH] send-email: new 'add-envelope' option
Message-ID: <7v1vjrmfjw.fsf@alter.siamese.dyndns.org>
In-Reply-To: <94a0d4530911211159l1fadad0ldb0d760439ceb57@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> There are no tests for 'envelope-sender', so I don't think it should
> be a requirement for this patch to do so....

The fact that the lack of test was pointed out as a problem makes it a
requirement.  Others' earlier mistakes are not an excuse for you to do a
poor job.

I do use --envelope-sender when sending patches out via msmtp.  What
wonderful things this patch adds am I missing in my current setup?