Re: [PATCH] send-email: new 'add-envelope' option
- From
Jeff King <peff@peff.net>
- Date
- Nov 21, 2009, 19:36 UTC
- Message-ID
- <20091121193600.GA3296@coredump.intra.peff.net>
- In-Reply-To
- <1258825410-28592-1-git-send-email-felipe.contreras@gmail.com>
On Sat, Nov 21, 2009 at 07:43:30PM +0200, Felipe Contreras wrote:
> Some MTAs make smart decisions based on the 'from' envelope (i.e. msmtp)
So my first thought was "how in the world is this different from setting the envelope sender?"
Reading the code, it seems:
Show 9 quoted lines
> - $raw_from = $envelope_sender if (defined $envelope_sender);
> + if (defined $envelope_sender) {
> + $raw_from = $envelope_sender;
> + $envelope_from = 1;
> + }
> $raw_from = extract_valid_address($raw_from);
> unshift (@sendmail_parameters,
> - '-f', $raw_from) if(defined $envelope_sender);
> + '-f', $raw_from) if(defined $envelope_from);that this is a boolean to mean "use the from address as the envelope sender".
It was of course all the more confusing for not being documented at all, but even if documented, --envelope-from is IMHO confusingly similar to --envelope-sender. Maybe --use-from-in-envelope would be a better name?
And of course, your patch is missing docs and tests.
-Peff