Re: [PATCH] send-email: new 'add-envelope' option
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Nov 23, 2009, 20:13 UTC
- Message-ID
- <94a0d4530911231213k6ec3d4f4hb7bc293b8ddf92e8@mail.gmail.com>
- In-Reply-To
- <7v6392h2d9.fsf@alter.siamese.dyndns.org>
On Sun, Nov 22, 2009 at 7:54 PM, Junio C Hamano <gitster@pobox.com> wrote:
> You can say that if you want to be difficult to work with, or you can be > that somebody yourself and make a difference.
Being difficult to work with goes both ways. You as a maintainer are entitled to say "I won't accept this without test cases", and I as a contributor am entitled to say "I'm not going to do that". Since I'm doing this on my free time I'd rather work on the things I like, which doesn't include writing test cases from scratch, primarily because I'm not familiar with them.
> Let me show you that we can be constructive for a change ;-) > > How about something trivial like this?
Looks good to me, but again, that doesn't say much.
Cheers.
-- Felipe Contreras