Re: [PATCH] send-email: new 'add-envelope' option

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Nov 21, 2009, 19:59 UTC
Message-ID: <94a0d4530911211159l1fadad0ldb0d760439ceb57@mail.gmail.com>
In-Reply-To: <20091121193600.GA3296@coredump.intra.peff.net>

On Sat, Nov 21, 2009 at 9:36 PM, Jeff King <peff@peff.net> wrote:

> So my first thought was "how in the world is this different from setting
> the envelope sender?"
>
> Reading the code, it seems:

[...]

Show 5 quoted lines

> that this is a boolean to mean "use the from address as the envelope
> sender".
>
> It was of course all the more confusing for not being documented at all,
> but even if documented,

Right, I forgot the one-liner for the help.

> --envelope-from is IMHO confusingly similar to
> --envelope-sender. Maybe --use-from-in-envelope would be a better name?

Ok. I don't have any opinion on the name.

> And of course, your patch is missing docs and tests.

There are no tests for 'envelope-sender', so I don't think it should be a requirement for this patch to do so. I'll add the documentation though.

Will resend v2.

-- 
Felipe Contreras