Re: [PATCH] send-email: new 'add-envelope' option

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Nov 22, 2009, 12:03 UTC
Message-ID: <94a0d4530911220403w7238dab7saf18830a89f2add5@mail.gmail.com>
In-Reply-To: <7v1vjrmfjw.fsf@alter.siamese.dyndns.org>

On Sun, Nov 22, 2009 at 4:58 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> There are no tests for 'envelope-sender', so I don't think it should
>> be a requirement for this patch to do so....
>
> The fact that the lack of test was pointed out as a problem makes it a
> requirement.  Others' earlier mistakes are not an excuse for you to do a
> poor job.

Maybe I should wait until somebody adds the tests to --envelope-sender before pushing this patch.

> I do use --envelope-sender when sending patches out via msmtp.  What
> wonderful things this patch adds am I missing in my current setup?

You need to specify your mail address when setting the variable,
right? I use multiple email addresses, so that when I change it
($EMAIL or user.email) the right one will be used in the envelope. If
I use 'sendemail.envelopesender' I would
 need to change it as well.

Another option is to do something like 'sendemail.envelopesender=auto'.

-- 
Felipe Contreras