Re: [PATCH 1/2] [RFC] Use --find- instead of --detect- as prefix for long forms of -M and -C.
- From
Kevin Ballard <kevin@sb.org>
- Date
- Nov 12, 2010, 03:00 UTC
- Message-ID
- <7884E3F5-D622-49E2-BEBE-12936F388C30@sb.org>
- In-Reply-To
- <1289420833-20602-2-git-send-email-ydirson@altern.org>
On Nov 10, 2010, at 12:27 PM, Yann Dirson wrote:
Show 14 quoted lines
> -M[<n>]:: > ---detect-renames[=<n>]:: > +--find-renames[=<n>]:: > ifndef::git-log[] > Detect renames. > endif::git-log[] > @@ -246,7 +246,7 @@ endif::git-log[] > hasn't changed. > > -C[<n>]:: > ---detect-copies[=<n>]:: > +--find-copies[=<n>]:: > Detect copies as well as renames. See also `--find-copies-harder`. > If `n` is specified, it has the same meaning as for `-M<n>`.
I'm not sure I like the wording --find-copies and --find-renames. Maybe I'm just being silly, but it sounds like those are directives, saying "I want you to find copies/renames", as opposed to just saying "while you're working you should also detect copies/renames". The original flag --find-copies-harder is a bit different, because it's modifying the action of finding copies rather than making finding copies the prime directive.
On the other hand, --detect-copies and --detect-renames sounds to me like you're just telling it that it should, well, detect copies/renames as it goes about its business.
-Kevin Ballard