git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] [RFC] Use --find- instead of --detect- as prefix for long forms of -M and -C.

From
Yann Dirson <ydirson@altern.org>
Date
Nov 10, 2010, 20:27 UTC
Message-ID
<1289420833-20602-2-git-send-email-ydirson@altern.org>
In-Reply-To
<1289420833-20602-1-git-send-email-ydirson@altern.org>
Rationale: this is both shorter to spell and consistent with
--find-copies-harder.
Signed-off-by: Yann Dirson <ydirson@altern.org>
---
 Documentation/diff-options.txt |    4 ++--
 diff.c                         |    8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
index bfd0b57..ed9c44e 100644
--- a/Documentation/diff-options.txt
+++ b/Documentation/diff-options.txt
@@ -230,7 +230,7 @@ eligible for being picked up as a possible source of a rename to
 another file.
 
 -M[<n>]::
---detect-renames[=<n>]::
+--find-renames[=<n>]::
 ifndef::git-log[]
 	Detect renames.
 endif::git-log[]
@@ -246,7 +246,7 @@ endif::git-log[]
 	hasn't changed.
 
 -C[<n>]::
---detect-copies[=<n>]::
+--find-copies[=<n>]::
 	Detect copies as well as renames.  See also `--find-copies-harder`.
 	If `n` is specified, it has the same meaning as for `-M<n>`.
 
diff --git a/diff.c b/diff.c
index d1c6b91..3837ffd 100644
--- a/diff.c
+++ b/diff.c
@@ -3145,14 +3145,14 @@ int diff_opt_parse(struct diff_options *options, const char **av, int ac)
 		if ((options->break_opt = diff_scoreopt_parse(arg)) == -1)
 			return -1;
 	}
-	else if (!prefixcmp(arg, "-M") || !prefixcmp(arg, "--detect-renames=") ||
-		 !strcmp(arg, "--detect-renames")) {
+	else if (!prefixcmp(arg, "-M") || !prefixcmp(arg, "--find-renames=") ||
+		 !strcmp(arg, "--find-renames")) {
 		if ((options->rename_score = diff_scoreopt_parse(arg)) == -1)
 			return -1;
 		options->detect_rename = DIFF_DETECT_RENAME;
 	}
-	else if (!prefixcmp(arg, "-C") || !prefixcmp(arg, "--detect-copies=") ||
-		 !strcmp(arg, "--detect-copies")) {
+	else if (!prefixcmp(arg, "-C") || !prefixcmp(arg, "--find-copies=") ||
+		 !strcmp(arg, "--find-copies")) {
 		if (options->detect_rename == DIFF_DETECT_COPY)
 			DIFF_OPT_SET(options, FIND_COPIES_HARDER);
 		if ((options->rename_score = diff_scoreopt_parse(arg)) == -1)
-- 
1.7.2.3
Previous: Yann DirsonNext: Thomas Rast
Message 2 of 17 in “rationalize diffcore-rename options and their doc”
  1. rationalize diffcore-rename options and their docYann Dirson, Nov 10, 2010
  2. 1/2 [RFC] Use --find- instead of --detect- as prefix for long forms of -M and -C.Yann Dirson, Nov 10, 2010
  3. Thomas RastNov 11, 2010
  4. Yann DirsonNov 11, 2010
  5. Thomas RastNov 11, 2010
  6. Yann DirsonNov 12, 2010
  7. Kevin BallardNov 12, 2010
  8. Miles BaderNov 12, 2010
  9. Yann DirsonNov 12, 2010
  10. Junio C HamanoNov 29, 2010
  11. Kevin BallardNov 29, 2010
  12. Junio C HamanoNov 30, 2010
  13. Yann DirsonNov 30, 2010
  14. Yann DirsonNov 29, 2010
  15. Junio C HamanoNov 29, 2010
  16. 2/2 Keep together options controlling the behaviour of diffcore-rename.Yann Dirson, Nov 10, 2010
  17. Junio C HamanoNov 16, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.