Re: [PATCH 1/2] [RFC] Use --find- instead of --detect- as prefix for long forms of -M and -C.
- From
Thomas Rast <trast@student.ethz.ch>
- Date
- Nov 11, 2010, 10:47 UTC
- Message-ID
- <201011111147.04365.trast@student.ethz.ch>
- In-Reply-To
- <1289420833-20602-2-git-send-email-ydirson@altern.org>
Yann Dirson wrote:
> Rationale: this is both shorter to spell and consistent with > --find-copies-harder.
[...]
> -M[<n>]:: > ---detect-renames[=<n>]:: > +--find-renames[=<n>]::
Umm. The reasoning seems ok for me, but the farthest you can go is deprecating the options. Removing them as in
> - else if (!prefixcmp(arg, "-M") || !prefixcmp(arg, "--detect-renames=") ||
> - !strcmp(arg, "--detect-renames")) {
> + else if (!prefixcmp(arg, "-M") || !prefixcmp(arg, "--find-renames=") ||
> + !strcmp(arg, "--find-renames")) {would break backwards compatibility.
--
Thomas Rast
trast@{inf,student}.ethz.ch