Re: [PATCH 1/2] [RFC] Use --find- instead of --detect- as prefix for long forms of -M and -C.
- From
- Yann Dirson <ydirson@free.fr>
- Date
- Nov 11, 2010, 11:44 UTC
- Message-ID
- <20101111114404.GF8911@home.lan>
- In-Reply-To
- <201011111147.04365.trast@student.ethz.ch>
On Thu, Nov 11, 2010 at 11:47:04AM +0100, Thomas Rast wrote:
Show 17 quoted lines
> Yann Dirson wrote:
> > Rationale: this is both shorter to spell and consistent with
> > --find-copies-harder.
> [...]
> > -M[<n>]::
> > ---detect-renames[=<n>]::
> > +--find-renames[=<n>]::
>
> Umm. The reasoning seems ok for me, but the farthest you can go is
> deprecating the options. Removing them as in
>
> > - else if (!prefixcmp(arg, "-M") || !prefixcmp(arg, "--detect-renames=") ||
> > - !strcmp(arg, "--detect-renames")) {
> > + else if (!prefixcmp(arg, "-M") || !prefixcmp(arg, "--find-renames=") ||
> > + !strcmp(arg, "--find-renames")) {
>
> would break backwards compatibility.I don't think we care with compatibility here, since those are not part of any release.
-- Yann