Re: [PATCH 1/2] [RFC] Use --find- instead of --detect- as prefix for long forms of -M and -C.
- From
Thomas Rast <trast@student.ethz.ch>
- Date
- Nov 11, 2010, 22:24 UTC
- Message-ID
- <201011112324.57572.trast@student.ethz.ch>
- In-Reply-To
- <20101111114404.GF8911@home.lan>
Yann Dirson wrote:
Show 21 quoted lines
> On Thu, Nov 11, 2010 at 11:47:04AM +0100, Thomas Rast wrote:
> > Yann Dirson wrote:
> > > Rationale: this is both shorter to spell and consistent with
> > > --find-copies-harder.
> > [...]
> > > -M[<n>]::
> > > ---detect-renames[=<n>]::
> > > +--find-renames[=<n>]::
> >
> > Umm. The reasoning seems ok for me, but the farthest you can go is
> > deprecating the options. Removing them as in
> >
> > > - else if (!prefixcmp(arg, "-M") || !prefixcmp(arg, "--detect-renames=") ||
> > > - !strcmp(arg, "--detect-renames")) {
> > > + else if (!prefixcmp(arg, "-M") || !prefixcmp(arg, "--find-renames=") ||
> > > + !strcmp(arg, "--find-renames")) {
> >
> > would break backwards compatibility.
>
> I don't think we care with compatibility here, since those are not
> part of any release.Ah well. You're right of course, but you could have mentioned that somewhere :-)
--
Thomas Rast
trast@{inf,student}.ethz.ch