git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] [RFC] Use --find- instead of --detect- as prefix for long forms of -M and -C.

From
YDYann Dirson <ydirson@free.fr>
Date
Nov 12, 2010, 07:21 UTC
Message-ID
<20101112072154.GJ3167@home.lan>
In-Reply-To
<201011112324.57572.trast@student.ethz.ch>
On Thu, Nov 11, 2010 at 11:24:57PM +0100, Thomas Rast wrote:
Show 25 quoted lines
> Yann Dirson wrote:
> > On Thu, Nov 11, 2010 at 11:47:04AM +0100, Thomas Rast wrote:
> > > Yann Dirson wrote:
> > > > Rationale: this is both shorter to spell and consistent with
> > > > --find-copies-harder.
> > > [...]
> > > >  -M[<n>]::
> > > > ---detect-renames[=<n>]::
> > > > +--find-renames[=<n>]::
> > > 
> > > Umm.  The reasoning seems ok for me, but the farthest you can go is
> > > deprecating the options.  Removing them as in
> > > 
> > > > -	else if (!prefixcmp(arg, "-M") || !prefixcmp(arg, "--detect-renames=") ||
> > > > -		 !strcmp(arg, "--detect-renames")) {
> > > > +	else if (!prefixcmp(arg, "-M") || !prefixcmp(arg, "--find-renames=") ||
> > > > +		 !strcmp(arg, "--find-renames")) {
> > > 
> > > would break backwards compatibility.
> > 
> > I don't think we care with compatibility here, since those are not
> > part of any release.
> 
> Ah well.  You're right of course, but you could have mentioned that
> somewhere :-)
Ah, I was sure I did, but apprently not :)
Previous: Thomas RastNext: Kevin Ballard
Message 6 of 17 in “rationalize diffcore-rename options and their doc”
  1. rationalize diffcore-rename options and their docYann Dirson, Nov 10, 2010
  2. 1/2 [RFC] Use --find- instead of --detect- as prefix for long forms of -M and -C.Yann Dirson, Nov 10, 2010
  3. Thomas RastNov 11, 2010
  4. Yann DirsonNov 11, 2010
  5. Thomas RastNov 11, 2010
  6. Yann DirsonNov 12, 2010
  7. Kevin BallardNov 12, 2010
  8. Miles BaderNov 12, 2010
  9. Yann DirsonNov 12, 2010
  10. Junio C HamanoNov 29, 2010
  11. Kevin BallardNov 29, 2010
  12. Junio C HamanoNov 30, 2010
  13. Yann DirsonNov 30, 2010
  14. Yann DirsonNov 29, 2010
  15. Junio C HamanoNov 29, 2010
  16. 2/2 Keep together options controlling the behaviour of diffcore-rename.Yann Dirson, Nov 10, 2010
  17. Junio C HamanoNov 16, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.