git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3 v2] send-email: correct logic error with --suppress-cc=cc

From
Jay Soffian <jaysoffian@gmail.com>
Date
Feb 14, 2009, 07:15 UTC
Message-ID
<76718490902132315l1a9d9463n255cdfe5cce15d22@mail.gmail.com>
In-Reply-To
<7viqndzf0o.fsf@gitster.siamese.dyndns.org>
On Sat, Feb 14, 2009 at 1:52 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Perhaps it is easier to clarify the goal by updating the tests to define
> what needs to happen first?  Working from tests often makes the end result
> much more robust than randomly modifying the existing code here and there
> until it happens to start doing something you think it should do.

In this case the problem is that the existing code had no tests, so I wasn't quite sure what it was supposed to do, and I divined the wrong thing from it.

But now that I understand what it should do, I'll add tests.
Who let the original code in w/o tests, hmm? :-)
j.
Previous: Junio C HamanoNext: Junio C Hamano
Message 14 of 20 in “send-email: handle multiple Cc addresses when reading mbox message”
  1. send-email: handle multiple Cc addresses when reading mbox messageJay Soffian, Feb 13, 2009
  2. Thomas RastFeb 13, 2009
  3. Jay SoffianFeb 13, 2009
  4. Jay SoffianFeb 13, 2009
  5. Jay SoffianFeb 14, 2009
  6. 1/3 send-email: correct logic error with --suppress-cc=ccJay Soffian, Feb 14, 2009
  7. 2/3 send-email: don't call unquote_rfc2047 unnecessarilyJay Soffian, Feb 14, 2009
  8. 3/3 send-email: --suppress-cc improvementsJay Soffian, Feb 14, 2009
  9. 3/3 send-email: --suppress-cc improvementsJay Soffian, Feb 14, 2009
  10. Junio C HamanoFeb 14, 2009
  11. Jay SoffianFeb 14, 2009
  12. 1/3 send-email: correct logic error with --suppress-cc=ccJay Soffian, Feb 14, 2009
  13. Junio C HamanoFeb 14, 2009
  14. Jay SoffianFeb 14, 2009
  15. Junio C HamanoFeb 14, 2009
  16. Thomas RastFeb 14, 2009
  17. Jeff KingFeb 14, 2009
  18. Jay SoffianFeb 14, 2009
  19. Jeff KingFeb 14, 2009
  20. Junio C HamanoFeb 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.