Re: [PATCH] send-email: handle multiple Cc addresses when reading mbox message

From: Jay Soffian <jaysoffian@gmail.com>
Date: Feb 14, 2009, 03:51 UTC
Message-ID: <1234583491-61260-1-git-send-email-jaysoffian@gmail.com>
In-Reply-To: <200902140032.19922.trast@student.ethz.ch>

From: Jay Soffian <jaysoffian@gmail.com>

On Fri, Feb 13, 2009 at 6:32 PM, Thomas Rast <trast@student.ethz.ch> wrote:

Show 12 quoted lines

> Jay Soffian wrote:
>> -                     if (/^(Signed-off-by|Cc): (.*)$/i) {
>> -                             next if ($suppress_cc{'sob'});
> [...]
>> +             if (/^(Signed-off-by|Cc): (.*)$/i) {
>> +                     next if ($suppress_cc{'sob'});
>
> Doesn't this actually look like a long-standing send-email bug?  Since
> 6564828 (git-send-email: Generalize auto-cc recipient mechanism.,
> 2007-12-25) they should go in separate categories, but the above lines
> were just translated from the old $signed_off_cc setting.  It seems
> they should distinguish between SOB and Cc.

This is fixed by the last patch in this series. While I was working on it I noticed two other minor issues, which is the first two patches.

This is meant to go on top of http://thread.gmane.org/gmane.comp.version-control.git/109783

Jay Soffian (3):
  send-email: correct logic error with --suppress-cc=cc
  send-email: don't call unquote_rfc2047 unnecessarily
  send-email: --suppress-cc improvements

 Documentation/git-send-email.txt |   14 ++++++----
 git-send-email.perl              |   50 ++++++++++++++++++++++----------------
 t/t9001-send-email.sh            |   38 +++++++++++++++++++++++++++-
 3 files changed, 73 insertions(+), 29 deletions(-)