git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] send-email: handle multiple Cc addresses when reading mbox message

From
Jeff King <peff@peff.net>
Date
Feb 14, 2009, 00:31 UTC
Message-ID
<20090214003113.GB7769@coredump.intra.peff.net>
In-Reply-To
<1234566313-36478-1-git-send-email-jaysoffian@gmail.com>
On Fri, Feb 13, 2009 at 06:05:13PM -0500, Jay Soffian wrote:
> This patch teaches it to unfold header lines by pre-processing the
> header before extracting any of its fields. It also teaches it to split
> the Cc line using Mail::Address if available, otherwise it just splits
> on a simple \s*,\s* regular expression.

Ugh. This is not in any way a comment on your patch, but it is really painful to see time and again send-email bugs like this that could be solved by using the wealth of existing perl modules.

I think send-email is stuck somewhere between "here is the bare minimum to send some patches, and we don't want to require any fancy dependencies" and "a full-fledged replacement for my MUA when dealing with patches".

The approach of "use this module if we have it, otherwise do something quick and dirty" might be the best approach. But I do wonder if the "quick and dirty" code path will end up buggy due to lack of use, and/or be surprising for people who expect send-email to be more thorough.

The other alternatives are to keep fixing bugs and improving incrementally until it converges on being an actual MUA, or to simply start a rewrite based on reasonable CPAN modules.

I don't know what the right solution is. I am certainly not volunteering to rewrite; I am very happy just using my actual MUA to send patches. :)

-Peff
Previous: Thomas RastNext: Jay Soffian
Message 17 of 20 in “send-email: handle multiple Cc addresses when reading mbox message”
  1. send-email: handle multiple Cc addresses when reading mbox messageJay Soffian, Feb 13, 2009
  2. Thomas RastFeb 13, 2009
  3. Jay SoffianFeb 13, 2009
  4. Jay SoffianFeb 13, 2009
  5. Jay SoffianFeb 14, 2009
  6. 1/3 send-email: correct logic error with --suppress-cc=ccJay Soffian, Feb 14, 2009
  7. 2/3 send-email: don't call unquote_rfc2047 unnecessarilyJay Soffian, Feb 14, 2009
  8. 3/3 send-email: --suppress-cc improvementsJay Soffian, Feb 14, 2009
  9. 3/3 send-email: --suppress-cc improvementsJay Soffian, Feb 14, 2009
  10. Junio C HamanoFeb 14, 2009
  11. Jay SoffianFeb 14, 2009
  12. 1/3 send-email: correct logic error with --suppress-cc=ccJay Soffian, Feb 14, 2009
  13. Junio C HamanoFeb 14, 2009
  14. Jay SoffianFeb 14, 2009
  15. Junio C HamanoFeb 14, 2009
  16. Thomas RastFeb 14, 2009
  17. Jeff KingFeb 14, 2009
  18. Jay SoffianFeb 14, 2009
  19. Jeff KingFeb 14, 2009
  20. Junio C HamanoFeb 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.