Re: [PATCH] send-email: handle multiple Cc addresses when reading mbox message

From: Jay Soffian <jaysoffian@gmail.com>
Date: Feb 13, 2009, 23:39 UTC
Message-ID: <76718490902131539o15439f12l7d4a8113f482c6ee@mail.gmail.com>
In-Reply-To: <200902140032.19922.trast@student.ethz.ch>

On Fri, Feb 13, 2009 at 6:32 PM, Thomas Rast <trast@student.ethz.ch> wrote:

Show 12 quoted lines

> Jay Soffian wrote:
>> -                     if (/^(Signed-off-by|Cc): (.*)$/i) {
>> -                             next if ($suppress_cc{'sob'});
> [...]
>> +             if (/^(Signed-off-by|Cc): (.*)$/i) {
>> +                     next if ($suppress_cc{'sob'});
>
> Doesn't this actually look like a long-standing send-email bug?  Since
> 6564828 (git-send-email: Generalize auto-cc recipient mechanism.,
> 2007-12-25) they should go in separate categories, but the above lines
> were just translated from the old $signed_off_cc setting.  It seems
> they should distinguish between SOB and Cc.

I think it would be nice if send-email had different settings for extracting Cc lines and extracting SOB lines from the message body, but I don't call that a bug, but rather an enhancement request.

And yes, I noticed it when I went to send this patch because originally I had "Cc: ..." in the commit message on column 0, which send-email annoyingly picked up. I just changed my commit message to move the "Cc:" to column 1.

Nonetheless, it is independent of this patch.

j.