git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] send-email: don't call unquote_rfc2047 unnecessarily

From
Jay Soffian <jaysoffian@gmail.com>
Date
Feb 14, 2009, 05:50 UTC
Message-ID
<76718490902132150w59d48581ke1c6394809bf810a@mail.gmail.com>
In-Reply-To
<1234583491-61260-3-git-send-email-jaysoffian@gmail.com>
On Fri, Feb 13, 2009 at 10:51 PM, Jay Soffian <jaysoffian@gmail.com> wrote:
Show 24 quoted lines
> From: Jay Soffian <jaysoffian@gmail.com>
>
> If --suppress-cc=author then there is no need to unquote the From:
> address.
>
> Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
> ---
>  git-send-email.perl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index a2e0b94..2a3e3e8 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -958,8 +958,8 @@ foreach my $t (@files) {
>                                $subject = $1;
>                        }
>                        elsif (/^From:\s+(.*)$/) {
> +                               next if $suppress_cc{'author'};
>                                ($author, $author_encoding) = unquote_rfc2047($1);
> -                               next if ($suppress_cc{'author'});
>                                printf("(mbox) Adding cc: %s from line '%s'\n",
>                                        $1, $_) unless $quiet;
>                                push @cc, $1;

Crap. Ignore this one from the series. $author is used later and we have to parse it regardless. This is brittle code, but I should've realize it.

j.
Previous: Junio C HamanoNext: Jay Soffian
Message 11 of 20 in “send-email: handle multiple Cc addresses when reading mbox message”
  1. send-email: handle multiple Cc addresses when reading mbox messageJay Soffian, Feb 13, 2009
  2. Thomas RastFeb 13, 2009
  3. Jay SoffianFeb 13, 2009
  4. Jay SoffianFeb 13, 2009
  5. Jay SoffianFeb 14, 2009
  6. 1/3 send-email: correct logic error with --suppress-cc=ccJay Soffian, Feb 14, 2009
  7. 2/3 send-email: don't call unquote_rfc2047 unnecessarilyJay Soffian, Feb 14, 2009
  8. 3/3 send-email: --suppress-cc improvementsJay Soffian, Feb 14, 2009
  9. 3/3 send-email: --suppress-cc improvementsJay Soffian, Feb 14, 2009
  10. Junio C HamanoFeb 14, 2009
  11. Jay SoffianFeb 14, 2009
  12. 1/3 send-email: correct logic error with --suppress-cc=ccJay Soffian, Feb 14, 2009
  13. Junio C HamanoFeb 14, 2009
  14. Jay SoffianFeb 14, 2009
  15. Junio C HamanoFeb 14, 2009
  16. Thomas RastFeb 14, 2009
  17. Jeff KingFeb 14, 2009
  18. Jay SoffianFeb 14, 2009
  19. Jeff KingFeb 14, 2009
  20. Junio C HamanoFeb 14, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.