From: Jay Soffian Date: Sat, 14 Feb 2009 07:15:45 GMT Subject: Re: [PATCH 1/3 v2] send-email: correct logic error with --suppress-cc=cc Message-ID: <76718490902132315l1a9d9463n255cdfe5cce15d22@mail.gmail.com> In-Reply-To: <7viqndzf0o.fsf@gitster.siamese.dyndns.org> On Sat, Feb 14, 2009 at 1:52 AM, Junio C Hamano wrote: > Perhaps it is easier to clarify the goal by updating the tests to define > what needs to happen first? Working from tests often makes the end result > much more robust than randomly modifying the existing code here and there > until it happens to start doing something you think it should do. In this case the problem is that the existing code had no tests, so I wasn't quite sure what it was supposed to do, and I divined the wrong thing from it. But now that I understand what it should do, I'll add tests. Who let the original code in w/o tests, hmm? :-) j.